[Typescript] allow Dofn to return promise #29925
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| process: ( | ||
| element: InputT, | ||
| context: ContextT, | ||
| ) => Iterable<OutputT> | void | Promise<Iterable<OutputT> | void>; |
There was a problem hiding this comment.
Is there a reason void is listed twice here?
| // Trying to get some of https://github.com/microsoft/TypeScript/issues/8240 | ||
| export const NonPromise = null; | ||
| export const isPromise = (x: any): x is Promise<any> => { | ||
| return x instanceof Promise; |
There was a problem hiding this comment.
In my initial tests this was expensive to do on every element call for every DoFn, but maybe I was over-optimizing. (There also didn't seem to be a standard way of checking for promises...maybe that's changed?)
| } | ||
|
|
||
| process(wvalue: WindowedValue<unknown>) { | ||
| async process(wvalue: WindowedValue<unknown>) { |
There was a problem hiding this comment.
So even if this doesn't return a promise, it always creates one (and does the other async overhead), right?
|
Reminder, please take a look at this pr: @jrmccluskey |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @jrmccluskey added as fallback since no labels match configuration Available commands:
|
|
stop reviewer notifications |
|
Stopping reviewer notifications for this pull request: requested by reviewer |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
4 participants
Simplified promise detection, and added await in case the
processfunction returned a promise, while not adding promises when not needed so to not add overheadaddresses #29915
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.