Skip to content

Conversation

@robertwb
Copy link
Contributor

@robertwb robertwb commented Jan 12, 2024

  • Clarify schema of elements from Create.
  • Better document naming parameter.
  • Move pipeline running instructions to the top.
  • Link to additonal resources.
  • Some clarification on the mapping docs.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@robertwb robertwb changed the title [YAML] Improve docs on create. [YAML] Several improvements to the documentation. Jan 12, 2024
This was pointed out as a pain point by multiple people.
These will get updated when we have proper docs, but it's still
good to surface what we have in the meantime.
@robertwb
Copy link
Contributor Author

R: @Polber

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Comment on lines +75 to +80
You can do a dry-run of your pipeline using the render runner to see what the
execution graph is, e.g.

```
python -m apache_beam.yaml.main --yaml_pipeline_file=/path/to/pipeline.yaml --runner=apache_beam.runners.render.RenderRunner --render_output=out.png [--render_port=0]
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to mention that graphviz must be installed. I had to install it using these instructions: https://graphviz.org/download/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Added.

```

Currently, in addition to Python, SQL expressions are supported as well
Currently, in addition to Python, Java and SQL expressions are supported as well
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to note experimental Javascript support

@robertwb robertwb merged commit ce28c33 into apache:master Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants