Skip to content

Cherry-pick #3006 into release-2.0.0#3010

Closed
tgroh wants to merge 1 commit intoapache:release-2.0.0from
tgroh:jsr305-shading-rls
Closed

Cherry-pick #3006 into release-2.0.0#3010
tgroh wants to merge 1 commit intoapache:release-2.0.0from
tgroh:jsr305-shading-rls

Conversation

@tgroh
Copy link
Member

@tgroh tgroh commented May 9, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

Shade JSR305 in the DirectRunner

None of the APIs exposed by the DirectRunner are nullable.

None of the APIs exposed by the DirectRunner are nullable.
@tgroh
Copy link
Member Author

tgroh commented May 9, 2017

R: @davorbonaci

Copy link
Member

@davorbonaci davorbonaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgroh
Copy link
Member Author

tgroh commented May 9, 2017

Will merge after #3006 is merged

asfgit pushed a commit that referenced this pull request May 9, 2017
@tgroh tgroh closed this May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants