Skip to content

Conversation

@damondouglas
Copy link
Contributor

@damondouglas damondouglas commented Feb 1, 2024

This PR addresses #29669 via implementation of jobservices.Server Cancel method.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (a221f98) 38.42% compared to head (0763a0c) 38.44%.
Report is 11 commits behind head on master.

Files Patch % Lines
sdks/go/pkg/beam/runners/prism/internal/execute.go 0.00% 4 Missing and 1 partial ⚠️
...pkg/beam/runners/prism/internal/jobservices/job.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #30178      +/-   ##
==========================================
+ Coverage   38.42%   38.44%   +0.02%     
==========================================
  Files         697      697              
  Lines      102215   102244      +29     
==========================================
+ Hits        39272    39305      +33     
+ Misses      61315    61309       -6     
- Partials     1628     1630       +2     
Flag Coverage Δ
go 54.22% <75.86%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damondouglas damondouglas marked this pull request as ready for review February 1, 2024 22:01
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@damondouglas damondouglas merged commit a47b1fa into apache:master Feb 5, 2024
@damondouglas damondouglas deleted the prism-cancel branch February 5, 2024 18:15
@lostluck
Copy link
Contributor

lostluck commented Feb 7, 2024

I'm late, but also LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants