[Dataflow Streaming] Invalidate caches and remove work on failure before commit #30229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
R: @scwhittle |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Contributor
Author
|
This is same as #30215, with logic to catch any exceptions thrown by completeWorkAndScheduleNextWorkForKey on the commit thread. |
arunpandianp
force-pushed
the
fixFailedWork
branch
from
22734d9 to
66af1ae
Compare
Contributor
Author
|
Modified completeWorkAndScheduleNextWorkForKey to not throw. |
scwhittle
approved these changes
Feb 6, 2024
3 tasks
lostluck
added a commit
that referenced
this pull request
Feb 6, 2024
… work on failure before commit (#30234) * Invalidate caches and remove work on failure before commit * Prevent completeWorkAndScheduleNextWorkForKey from throwing --------- Co-authored-by: Arun Pandian <pandiana@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.