Fixes a bug related to upgrading Kafka read transforms using the Transform Service #30264
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
assign set of reviewers |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| } | ||
|
|
||
| if (transform.getTopicPartitions() != null) { | ||
| if (transform.getTopicPartitions() != null && !transform.getTopicPartitions().isEmpty()) { |
There was a problem hiding this comment.
IIRC there's a nullOrEmpty utility function.
There was a problem hiding this comment.
I couldn't find one or add one that also satisfies the checker-framework nullness check. So leaving as is.
| } | ||
| Collection<Row> topicPartitionRows = configRow.getArray("topic_partitions"); | ||
| if (topicPartitionRows != null) { | ||
| if (topicPartitionRows != null && !topicPartitionRows.isEmpty()) { |
There was a problem hiding this comment.
I couldn't find one or add one that also satisfies the checker-framework nullness check. So leaving as is.
| } | ||
|
|
||
| if (transform.getTopicPartitions() != null) { | ||
| if (transform.getTopicPartitions() != null && !transform.getTopicPartitions().isEmpty()) { |
There was a problem hiding this comment.
I couldn't find one or add one that also satisfies the checker-framework nullness check. So leaving as is.
| } | ||
| Collection<Row> topicPartitionRows = configRow.getArray("topic_partitions"); | ||
| if (topicPartitionRows != null) { | ||
| if (topicPartitionRows != null && !topicPartitionRows.isEmpty()) { |
There was a problem hiding this comment.
I couldn't find one or add one that also satisfies the checker-framework nullness check. So leaving as is.
2 participants
This fixes #30263.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.