fix: support reading arrays of structs from bigquery with schemas #30448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fixes #29565 |
Contributor
Author
|
R: @riteshghorse |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Contributor
Author
|
Ping for reviewers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BigQuery clients sometimes * returns arrays as lists of KV maps with key "v". We handle this by unwrapping the value before doing further processing.
When we read arrays of structs, we shouldn't carelessly unwrap this map. This PR adds a check to only do so if the only key is "v", which indicates the case mentioned above.