-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Use 50 workers for 2GB 10 bytes combine test #30655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Do you think there is some inefficiency? do we need 10x workers for this test in streaming mode or batch and streaming tests are fundamentally different? |
|
is 2GB the total # of bytes processed? |
|
+1, needs 50 workers to proceed 2 GB data sounds not quite right in general. There must be some underlying issue that actually need to be resolved. |
Yes. The problem is |
|
Can we change the cron string to sth like '50 5 * * *' so the risk of interfering with other workflow is minimum
|
Good idea. Done. Thanks. |
|
merge now and let's see how it goes |
* Use 50 workers for 2GB 10 bytes combine test * updated the cron schedule
python_Combine_Dataflow_Streaming_2GB_10_byte_records.txtfailed due to the limited number of workers. Increase this to 50, which should finish the test within 2 hours (~16$).Tests are here:
beam/sdks/python/apache_beam/testing/load_tests/combine_test.py
Line 121 in 50f33cd
Cron:
https://github.com/apache/beam/blob/50f33cd786dc63463688315a1c73b1cf4ef18807/.github/workflows/beam_LoadTests_Python_Combine_Dataflow_Streaming.yml#L20C14-L20C25
Fixes #23904
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.