Skip to content

Conversation

@liferoad
Copy link
Contributor

@liferoad liferoad commented Mar 16, 2024

python_Combine_Dataflow_Streaming_2GB_10_byte_records.txt failed due to the limited number of workers. Increase this to 50, which should finish the test within 2 hours (~16$).

Tests are here:

beam.combiners.TopCombineFn(self.top_count)).without_defaults()

Cron:
https://github.com/apache/beam/blob/50f33cd786dc63463688315a1c73b1cf4ef18807/.github/workflows/beam_LoadTests_Python_Combine_Dataflow_Streaming.yml#L20C14-L20C25

Fixes #23904


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@liferoad liferoad requested a review from tvalentyn March 16, 2024 22:43
@github-actions github-actions bot added the build label Mar 16, 2024
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tvalentyn
Copy link
Contributor

Do you think there is some inefficiency? do we need 10x workers for this test in streaming mode or batch and streaming tests are fundamentally different?

@tvalentyn
Copy link
Contributor

is 2GB the total # of bytes processed?

@Abacn
Copy link
Contributor

Abacn commented Mar 18, 2024

+1, needs 50 workers to proceed 2 GB data sounds not quite right in general. There must be some underlying issue that actually need to be resolved.

@liferoad
Copy link
Contributor Author

is 2GB the total # of bytes processed?

Yes. The problem is beam.CombineGlobally(beam.combiners.TopCombineFn(self.top_count)).without_defaults() does the sorting on all (k, v) pairs.

@Abacn
Copy link
Contributor

Abacn commented Mar 19, 2024

Can we change the cron string to sth like '50 5 * * *' so the risk of interfering with other workflow is minimum

@liferoad
Copy link
Contributor Author

Can we change the cron string to sth like '50 5 * * *' so the risk of interfering with other workflow is minimum

Good idea. Done. Thanks.

@Abacn
Copy link
Contributor

Abacn commented Mar 19, 2024

merge now and let's see how it goes

@Abacn Abacn merged commit 4513eaa into apache:master Mar 19, 2024
hjtran pushed a commit to hjtran/beam that referenced this pull request Apr 4, 2024
* Use 50 workers for 2GB 10 bytes combine test

* updated the cron schedule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: beam_LoadTests_Python_Combine_Dataflow_Streaming failing

3 participants