Skip to content

[BEAM-1345] Mark internal modules in python datastoreio#3088

Closed
vikkyrk wants to merge 1 commit intoapache:masterfrom
vikkyrk:py_doc
Closed

[BEAM-1345] Mark internal modules in python datastoreio#3088
vikkyrk wants to merge 1 commit intoapache:masterfrom
vikkyrk:py_doc

Conversation

@vikkyrk
Copy link
Contributor

@vikkyrk vikkyrk commented May 11, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@vikkyrk vikkyrk changed the title Mark internal modules in python datastoreio [BEAM-1345] Mark internal modules in python datastoreio May 11, 2017
@vikkyrk
Copy link
Contributor Author

vikkyrk commented May 11, 2017

R: @aaltay

@aaltay
Copy link
Member

aaltay commented May 11, 2017

LGTM

@asfgit asfgit closed this in 0b0bb41 May 11, 2017
@dhalperi
Copy link
Contributor

This broke lint in post-commit.

apache_beam/io/gcp/datastore/v1/fake_datastore.py:34:1: E302 expected 2 blank lines, found 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants