[BEAM-1345] Add internal comments to metrics#3099
Closed
aaltay wants to merge 2 commits intoapache:masterfrom
Closed
[BEAM-1345] Add internal comments to metrics#3099aaltay wants to merge 2 commits intoapache:masterfrom
aaltay wants to merge 2 commits intoapache:masterfrom
Conversation
robertwb
reviewed
May 11, 2017
| from apache_beam.metrics.metricbase import MetricName | ||
|
|
||
|
|
||
| __all__ = ['Metrics', 'MetricsFilter'] |
Contributor
There was a problem hiding this comment.
MetricsFilter is Experimental in Java, should be marked as such below.
| from apache_beam.metrics.cells import CounterCell, DistributionCell | ||
|
|
||
| __all__ = [ | ||
| 'MetricKey', 'MetricResult', 'MetricsEnvironment', 'MetricsContainer'] |
Contributor
There was a problem hiding this comment.
Should these all be public? Likely not any of them?
Member
Author
There was a problem hiding this comment.
Maybe MetricResult and MetricKey only?
Contributor
There was a problem hiding this comment.
Neither show up in init. Where are they used? I'd rather publish them later than sooner, especially as the metrics query API is still experimental.
Member
Author
There was a problem hiding this comment.
They are not used, and the file already has an internal comment, I will revert this.
Member
Author
|
PTAL. |
Contributor
|
LGTM |
|
Changes Unknown when pulling 1960acf on aaltay:metr into ** on apache:master**. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R: @robertwb @chamikaramj
cc: @pabloem