Slightly more informative message. #31459
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
R: @robertwb |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
tvalentyn
commented
May 30, 2024
| 'Data output stream buffer size %s exceeds %s bytes. ' | ||
| 'This is likely due to a large element in a PCollection. ' | ||
| 'This is likely caused by a large element in a PCollection ' | ||
| 'that is passed between different fused stages. ' |
Contributor
Author
There was a problem hiding this comment.
might be too dataflow specific. ...that is passed between the SDK and a runner might be better.
Contributor
|
Given that fusion boundaries are an implementation detail outside the users direct control IMHO I don't think it's worth putting that detail here. Better to avoid large elements in general than to try and reason where they may or may not be OK for a particular optimization of a pipeline. |
Contributor
Author
|
makes sense, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be a slightly better message that suggests to not pass large elements across a fusion boundary.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.