-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Migrate Gradle Enterprise Plugin to Develocity Plugin #31577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This LGTM, would you just mind resolving conflicts? We should also verify that the whitespace failure is just a flake (it looks like it to me though)
This plugin replaces the legacy Gradle Enterprise with no change in functionality.
aec7355 to
1f55b83
Compare
|
Merge confict is fixed 👍 I suspect the whitespace check is a flake here too. I ran it locally from the new commit and it passed successfully: https://ge.solutions-team.gradle.com/s/72mmccuyaynyg/console-log?page=2#L1534. But I'm also not familiar with what all it is checking for. |
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
I think this PR is causing the below build error on My best guess is that Kotlin version need to use .set() instead of assignment. |
|
@tommyang - what version of Gradle are you building with? The |
|
@clayburn Thanks for the explanation. It was indeed because the Gradle version of our particular repo was out of date. Long story short, that repo has its another Gradle project with an old wrapper and the build script invoked that for Beam src code as well. Sorry for the noise. |
|
No problem, glad to help! |
This PR updates usage of the
com.gradle.enterpriseplugin to the equivalentcom.gradle.develocityplugin as a result of renaming Gradle Enterprise to Develocity. This change will result in no functional changes to the Beam project.For convenience, the changes have been broken up into 4 commits:
develocityconfigurationThank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.