[BEAM-2310] support new data type: DECIMAL#3168
Closed
xumingming wants to merge 3 commits intoapache:DSL_SQLfrom
Closed
[BEAM-2310] support new data type: DECIMAL#3168xumingming wants to merge 3 commits intoapache:DSL_SQLfrom
xumingming wants to merge 3 commits intoapache:DSL_SQLfrom
Conversation
Member
|
R: @jbonofre |
mingmxu
reviewed
May 18, 2017
| } | ||
|
|
||
| instantCoder.encode(value.getWindowStart(), outStream, context.nested()); | ||
| instantCoder.encode(value.getWindowStart(), outStream, context); |
There was a problem hiding this comment.
would keep as context.nested(), and only has the last field in coder/decoder as context,
Same for method decode.
Contributor
Author
There was a problem hiding this comment.
Is there any criteria for this reason? I don't quite understand the context/context.nested() thing, my current strategy is just to keep consistent in encode/decode.
There was a problem hiding this comment.
I would follow the pattern to have only the last field as context, and context().nested() with others.
Contributor
Author
|
@jbonofre can you take a look at this one? |
jbonofre
approved these changes
May 24, 2017
Member
jbonofre
left a comment
jbonofre
left a comment
There was a problem hiding this comment.
LGTM, I'm resolving conflict and merging.
Member
|
Merged on |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R: @xumingmin