Skip to content

[BEAM-2334] Fix OutOfMemoryError#3189

Closed
yonromai wants to merge 2 commits into
apache:masterfrom
yonromai:patch-1
Closed

[BEAM-2334] Fix OutOfMemoryError#3189
yonromai wants to merge 2 commits into
apache:masterfrom
yonromai:patch-1

Conversation

@yonromai
Copy link
Copy Markdown
Contributor

@yonromai yonromai commented May 19, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@lukecwik
Copy link
Copy Markdown
Member

R: @lukecwik

@lukecwik
Copy link
Copy Markdown
Member

lukecwik commented May 19, 2017

Looking around at SO, it seems as though people use Integer.MAX_VALUE - 5 or Integer.MAX_VALUE - 8, Why did you do Integer.MAX_VALUE - 2?

http://stackoverflow.com/questions/3038392/do-java-arrays-have-a-maximum-size

I would go with the Integer.MAX_VALUE - 8 based upon the above SO question.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.01%) to 70.657% when pulling c62c1da on yonromai:patch-1 into ce00d24 on apache:master.

@lukecwik
Copy link
Copy Markdown
Member

retest this please

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.02%) to 70.652% when pulling c62c1da on yonromai:patch-1 into ce00d24 on apache:master.

@lukecwik
Copy link
Copy Markdown
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants