Skip to content

Remove builder method tests from BigtableIO, it uses AutoValue now#3208

Closed
iemejia wants to merge 1 commit intoapache:masterfrom
iemejia:remove-bigtableio-tests
Closed

Remove builder method tests from BigtableIO, it uses AutoValue now#3208
iemejia wants to merge 1 commit intoapache:masterfrom
iemejia:remove-bigtableio-tests

Conversation

@iemejia
Copy link
Member

@iemejia iemejia commented May 23, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@iemejia
Copy link
Member Author

iemejia commented May 23, 2017

R: @dhalperi

@dhalperi
Copy link
Contributor

Why is this code not still providing useful coverage?

Specifically, it tests that the code that we wrote around the AutoValue builder is correct.

@dhalperi
Copy link
Contributor

@iemejia
Copy link
Member Author

iemejia commented May 23, 2017

You have a point, I did this PR since I have seen some discussion around removing 'obvious' test cases in the moment we were reviewing the PTransform/IO guides. If this is not the expected behavior I will close then this PR.

@iemejia iemejia closed this May 24, 2017
@iemejia iemejia deleted the remove-bigtableio-tests branch May 24, 2017 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants