Update maven-dependency-plugin to version 3.0.1#3219
Merged
Conversation
Member
Author
|
R: @jbonofre |
jbonofre
approved these changes
May 24, 2017
Member
jbonofre
left a comment
jbonofre
left a comment
There was a problem hiding this comment.
LGTM. I'm waiting Jenkins pass before merging.
iemejia
force-pushed
the
update-dependency-plugin
branch
from
da11a5d to
8b0e4bc
Compare
Member
Author
|
I had to rebase to add two extra missing dependencies found by the new version of the plugin. |
Member
|
retest this please |
Member
|
The build fails on python, I'm checking on my machine. |
Member
Author
|
It looks good now it seems. |
Member
|
It looks good now ! |
Member
Author
|
Can you merge it, or do I? |
Member
|
Done |
Member
Author
|
Thx JB. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.