More robust gen_protos on jenkins.#3224
Closed
robertwb wants to merge 2 commits into
Closed
Conversation
Don't use the globally shared build directory, which pip may refuse to use if there's a failed install.
Contributor
Author
|
R: @aaltay |
aaltay
reviewed
May 25, 2017
| build_path = install_path + '-build' | ||
| if os.path.exists(build_path): | ||
| shutil.rmtree(build_path) | ||
| logging.warning('Downloading a grpcio-tools to %s' % install_path) |
| logging.warning('Downloading a grpcio-tools to %s' % install_path) | ||
| subprocess.check_call( | ||
| ['pip', 'install', '-t', install_path, '--upgrade', GRPC_TOOLS]) | ||
| ['pip', 'install', '-t', install_path, '-b', build_path, |
Contributor
Author
|
Thanks. |
Contributor
|
This PR seems to greatly slow down Can still be worked around by adding |
Contributor
Author
|
On most machines pre-compiled wheels should be available to avoid compiling
all the C code. (This is, in fact, why I'm avoiding setup_requires...) What
system are you using?
Even faster is simply installing grcpio_tools into your Python (it checks
to see if it's available before fetching it.)
…On Thu, May 25, 2017 at 1:53 PM, Eugene Kirpichov ***@***.***> wrote:
This PR seems to greatly slow down mvn clean compile because now instead
of just compiling Java code, this also installs some python packages and
compiles a ton of C code.
Can still be worked around by adding -pl '!sdks/python', which brings
time for mvn clean compile test-compile from 5:30 minutes to 1:30.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3224 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAdqgRi02dVO0TZnnLFRBcl3odo3qDtUks5r9epUgaJpZM4Nmqeb>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't use the globally shared build directory, which pip may refuse
to use if there's a failed install.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.