[BEAM-2366] Don't try to pickle gen_protos in tests.#3228
Closed
robertwb wants to merge 1 commit into
Closed
Conversation
Tests that pickle the main session but are run from setup.py attempt to pickle everything visible in setup.py.
Contributor
Author
Member
|
Error is seems to be related to the cleanup of generated protos: "stderr: fatal: Not a git repository: sdks/python/.eggs/grpcio-wheels-build/grpcio/third_party/boringssl/../../.git/modules/third_party/boringssl" Could you also run a post commit with this change? |
Contributor
Author
|
Well that's a new error... Jenkins: retest this please. Also running post-commit at https://builds.apache.org/view/Beam/job/beam_PostCommit_Python_Verify/2318/ |
Member
|
It might be a leftover file that is causing an error. I am not sure how well jenkins does the cleanup. |
Contributor
Author
|
IIRC, cleanup on Jenkins is spotty at best.
…On Thu, May 25, 2017 at 4:39 PM, Ahmet Altay ***@***.***> wrote:
It might be a leftover file that is causing an error. I am not sure how
well jenkins does the cleanup.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3228 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAdqgcqcDkVg3lo6hZs47dASvflyYt3Vks5r9hFGgaJpZM4NnAPt>
.
|
Contributor
Author
|
retest this please |
Contributor
Author
|
R: @chamikaramj |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests that pickle the main session but are run from setup.py attempt
to pickle everything visible in setup.py.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.