Skip to content

Beam-2329 ABS function#3236

Closed
app-tarush wants to merge 3 commits into
apache:DSL_SQLfrom
app-tarush:beam-2329-abs-function
Closed

Beam-2329 ABS function#3236
app-tarush wants to merge 3 commits into
apache:DSL_SQLfrom
app-tarush:beam-2329-abs-function

Conversation

@app-tarush
Copy link
Copy Markdown
Contributor

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

Hi @xumingming , can you please take a look? I have break it into jira tickets wise.

@app-tarush app-tarush changed the base branch from master to DSL_SQL May 26, 2017 10:27
@coveralls
Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 6e5ad90 on app-tarush:beam-2329-abs-function into ** on apache:DSL_SQL**.

@app-tarush app-tarush mentioned this pull request May 26, 2017
4 tasks
@xumingming
Copy link
Copy Markdown
Contributor

LGTM

@xumingming
Copy link
Copy Markdown
Contributor

@jbonofre can you take a peek at this one?

@jbonofre
Copy link
Copy Markdown
Member

R: @jbonofre

Sure ! Thanks !

Copy link
Copy Markdown
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm merging.

asfgit pushed a commit that referenced this pull request Jun 6, 2017
@jbonofre
Copy link
Copy Markdown
Member

jbonofre commented Jun 6, 2017

Merged on DSL_SQL. Can you please close this PR ? Thanks !

@app-tarush app-tarush closed this Jun 6, 2017
@app-tarush app-tarush deleted the beam-2329-abs-function branch June 6, 2017 09:56
@app-tarush
Copy link
Copy Markdown
Contributor Author

@jbonofre @xumingming Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants