BEAM-2369 HadoopFileSystem: prevent NPE on match of non existing file#3237
Closed
adude3141 wants to merge 1 commit into
Closed
BEAM-2369 HadoopFileSystem: prevent NPE on match of non existing file#3237adude3141 wants to merge 1 commit into
adude3141 wants to merge 1 commit into
Conversation
lukecwik
requested changes
May 26, 2017
| try { | ||
| FileStatus[] fileStatuses = fileSystem.globStatus(new Path(spec)); | ||
| if (fileStatuses == null) { | ||
| return resultsBuilder.add(MatchResult.create(Status.NOT_FOUND, |
Member
There was a problem hiding this comment.
I don't think you want to return here yet, we should look up the rest of the results requested in the specs list.
| // ensure files exist | ||
| assertArrayEquals("testDataAA".getBytes(), read("testFileAA")); | ||
|
|
||
| List<MatchResult> matchResults = fileSystem.match( |
Member
There was a problem hiding this comment.
Test with a list of requested matches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
Hi @lukecwik, @dhalperi, plz have a look