Skip to content

Rename class Logger object names to the standard convention 'LOG'#3251

Closed
iemejia wants to merge 1 commit intoapache:masterfrom
iemejia:normalize-logger-names
Closed

Rename class Logger object names to the standard convention 'LOG'#3251
iemejia wants to merge 1 commit intoapache:masterfrom
iemejia:normalize-logger-names

Conversation

@iemejia
Copy link
Member

@iemejia iemejia commented May 28, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@iemejia
Copy link
Member Author

iemejia commented May 28, 2017

A really simple PR for some classes that are violating the Logger naming convention.
R: @jbonofre

@jbonofre
Copy link
Member

Fair enough. I'm reviewing.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 70.7% when pulling 55ccd32 on iemejia:normalize-logger-names into 27dd7a9 on apache:master.

Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm merging. Thanks !

@asfgit asfgit closed this in b833006 Jun 1, 2017
@iemejia
Copy link
Member Author

iemejia commented Jun 1, 2017

Thanks JB.

@iemejia iemejia deleted the normalize-logger-names branch June 2, 2017 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants