[BEAM-2380] Forward additional outputs to DoFnRunner in Flink Batch#3258
Merged
asfgit merged 2 commits intoMay 30, 2017
Merged
Conversation
Closed
4 tasks
Contributor
Author
|
Run Flink ValidatesRunner |
Contributor
Author
|
Build finished. |
1 similar comment
|
Build finished. |
Before, we only flushed all pushed-back data when receiving a +Inf watermark on the side input. It can happen that we receive that watermark before getting any data on the main input. This changes DoFnOperator to also flush when receiving a main-input watermark and we happen to have already received the +Inf watermark on the side input. Some tests where Flaky because of this. One example was ViewTest.testWindowedSideInputFixedToFixedWithDefault().
Contributor
Author
|
Run Flink ValidatesRunner |
|
Build finished. |
Contributor
Author
|
Succesfull Jenkins run: https://builds.apache.org/view/Beam/job/beam_PostCommit_Java_ValidatesRunner_Flink/2970/ |
|
Build finished. |
Member
|
retest this please |
Member
|
Run Flink ValidatesRunner |
|
--none-- |
1 similar comment
|
--none-- |
Contributor
|
LGTM, thanks! cc: @tgroh |
Member
|
Thanks for merging @dhalperi I was AFK most of the day but expected to do it later on. |
Contributor
Author
|
Thanks @dhalperi! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R: @iemejia or anyone, really 😃