Skip to content

[BEAM-1347] Add additional logging #3296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lukecwik wants to merge 2 commits into from
Closed

[BEAM-1347] Add additional logging #3296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae858a5
[BEAM-1347] Add additional logging
lukecwik Jun 5, 2017
614dede
Merge branch 'master' into fn_api
lukecwik Jun 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/BeamFnControlClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public BeamFnControlClient(
private class InboundObserver implements StreamObserver<BeamFnApi.InstructionRequest> {
@Override
public void onNext(BeamFnApi.InstructionRequest value) {
LOG.info("InstructionRequest received {}", value);
LOG.debug("Received InstructionRequest {}", value);
Uninterruptibles.putUninterruptibly(bufferedInstructions, value);
}

Expand Down Expand Up @@ -155,6 +155,7 @@ public BeamFnApi.InstructionResponse delegateOnInstructionRequestType(
}

public void sendInstructionResponse(BeamFnApi.InstructionResponse value) {
LOG.debug("Sending InstructionResponse {}", value);
outboundObserver.onNext(value);
}

Expand Down
5 changes: 4 additions & 1 deletion sdks/java/harness/src/main/java/org/apache/beam/fn/harness/data/BeamFnDataGrpcClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public <T> CompletableFuture<Void> forInboundConsumer(
KV<String, BeamFnApi.Target> inputLocation,
Coder<WindowedValue<T>> coder,
ThrowingConsumer<WindowedValue<T>> consumer) {
LOG.debug("Registering consumer instruction {} for target {}",
LOG.debug("Registering consumer for instruction {} and target {}",
inputLocation.getKey(),
inputLocation.getValue());

Expand Down Expand Up @@ -106,6 +106,9 @@ public <T> CloseableThrowingConsumer<WindowedValue<T>> forOutboundConsumer(
Coder<WindowedValue<T>> coder) {
BeamFnDataGrpcMultiplexer client = getClientFor(apiServiceDescriptor);

LOG.debug("Creating output consumer for instruction {} and target {}",
outputLocation.getKey(),
outputLocation.getValue());
return new BeamFnDataBufferingOutboundObserver<>(
options, outputLocation, coder, client.getOutboundObserver());
}
Expand Down
3 changes: 2 additions & 1 deletion ...java/harness/src/main/java/org/apache/beam/fn/harness/data/BeamFnDataGrpcMultiplexer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ public void onNext(BeamFnApi.Elements value) {
KV.of(data.getInstructionReference(), data.getTarget());
CompletableFuture<Consumer<BeamFnApi.Elements.Data>> consumer = futureForKey(key);
if (!consumer.isDone()) {
LOG.debug("Received data for key {} without consumer ready.", key);
LOG.debug("Received data for key {} without consumer ready. "
+ "Waiting for consumer to be registered.", key);
}
consumer.get().accept(data);
if (data.getData().isEmpty()) {
Expand Down