[BEAM-991] Raise entities limit per RPC to 9MB.#3302
Closed
cph6 wants to merge 1 commit intoapache:masterfrom
Closed
[BEAM-991] Raise entities limit per RPC to 9MB.#3302cph6 wants to merge 1 commit intoapache:masterfrom
cph6 wants to merge 1 commit intoapache:masterfrom
Conversation
This is closer to the API limit, while still leaving room for overhead. Brings the Java SDK into line with the Python SDK. Switch the unit test to use the size of each entity, which is what the connector is actually using, rather than the property size (which is slightly smaller and would cause the test to fail for some values).
Member
|
R: @vikkyrk |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is closer to the API limit, while still leaving room for overhead, and brings
the Java SDK back into line with the Python SDK.
Switch the unit test to use the size of each entity, which is what the
connector is actually using, rather than the property size (which is slightly
smaller and would cause the test to fail for some values).