Skip to content

propogate descriptions for nested Beam Rows during schema translation #33046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertwb merged 1 commit into from
Nov 19, 2024
Merged

propogate descriptions for nested Beam Rows during schema translation #33046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion sdks/python/apache_beam/typehints/schemas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,13 +513,17 @@ def typing_from_runner_api(
# generate a NamedTuple type to use.

fields = named_fields_from_schema(schema)
descriptions = {
field.name: field.description
for field in schema.fields
}
result = row_type.RowTypeConstraint.from_fields(
fields=fields,
schema_id=schema.id,
schema_options=schema_options,
field_options=field_options,
schema_registry=self.schema_registry,
)
field_descriptions=descriptions or None)
return result
else:
return row_type.RowTypeConstraint.from_user_type(
Expand Down