[BEAM-2421] Swap to use an Impulse primitive + DoFn for Create when executing with the Fn API.#3312
Closed
lukecwik wants to merge 4 commits intoapache:masterfrom
Closed
[BEAM-2421] Swap to use an Impulse primitive + DoFn for Create when executing with the Fn API.#3312lukecwik wants to merge 4 commits intoapache:masterfrom
lukecwik wants to merge 4 commits intoapache:masterfrom
Conversation
…erride implementations
…xecuting with the Fn API.
lukecwik
changed the title
Member
Author
|
R: @tgroh |
tgroh
reviewed
Jun 7, 2017
| overridesBuilder.add( | ||
| PTransformOverride.of( | ||
| PTransformMatchers.classEqualTo(Create.Values.class), | ||
| new ReflectiveRootOverrideFactory(StreamingFnApiCreate.class, this))); |
Member
There was a problem hiding this comment.
I would strongly consider making this a "real" (precise?) OverrideFactory
|
|
||
| /** | ||
| * A DoFn which stores encoded versions of elements and a representation of a Coder | ||
| * capable of decoding those elements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.