[BEAM-2410] Remove TransportClient from ElasticSearchIO#3328
Closed
echauchot wants to merge 1 commit into
Closed
Conversation
Member
|
Waiting @jkff approval to merge (as we are both reviewer on the pull request). |
…O and ES server versions
echauchot
force-pushed
the
BEAM-2410-ELASTICSEARCHIO-REMOVE-TRANSPORTCLIENT
branch
from
a41afd4 to
485a37d
Compare
Contributor
Author
|
pushed and squashed a little fix commit in the IT standalone injection part (close restClient in a finally block in ElasticsearchTestDataSet#createAndPopulateReadIndex) |
jkff
approved these changes
Jun 8, 2017
Contributor
jkff
left a comment
jkff
left a comment
There was a problem hiding this comment.
Don't see any issues as far as I'm concerned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
This PR is a first step to support Elasticsearch 5.x but it is also very useful for the IO that supports Elasticsearch 2.x, hence the separate PR.
R: @jbonofre
R: @jkff
CC: @ssisk regarding my comment https://issues.apache.org/jira/browse/BEAM-2347?focusedCommentId=16022861&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16022861. Besides, this impacts UT but also IT