[BEAM-2440] BeamSql: reduce visibility#3364
Merged
asfgit merged 1 commit intoapache:DSL_SQLfrom Jun 16, 2017
Merged
Conversation
Contributor
Author
|
R: @xumingmin |
Contributor
Author
|
Retest this please. |
Contributor
|
Can you swap me for Luke as reviewer on this please? Luke is trying to focus on Fn API going forward as much as possible. |
Contributor
Author
xumingming
force-pushed
the
BEAM-2440-reduce-visibility
branch
from
90cee32 to
5b756b8
Compare
xumingming
force-pushed
the
BEAM-2440-reduce-visibility
branch
from
5b756b8 to
fc5906e
Compare
Contributor
Author
|
Rebase done. |
Contributor
|
Merging, thank you! |
Contributor
|
Merged, feel free to close. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the packages are cross-importing each other, many of them can't be set to
package privateaccess level.