Skip to content

Use cached license files during pulling licenses.#33787

Merged
Abacn merged 2 commits intoapache:masterfrom
shunping:pull-licenses
Jan 29, 2025
Merged

Use cached license files during pulling licenses.#33787
Abacn merged 2 commits intoapache:masterfrom
shunping:pull-licenses

Conversation

@shunping
Copy link
Copy Markdown
Collaborator

addresses ##32161

@shunping
Copy link
Copy Markdown
Collaborator Author

shunping commented Jan 29, 2025

r: @damccorm @Abacn

cc: @ahmedabu98 @Amar3tto

@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Copy Markdown
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks good to me.

Note that we already did the same approach of caching license in #16692 , this expand it to all license entries

@Abacn
Copy link
Copy Markdown
Contributor

Abacn commented Jan 29, 2025

merge for now to unblock dev container release

@Abacn Abacn merged commit 081bb98 into apache:master Jan 29, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.47%. Comparing base (8f32cc4) to head (c7fbe68).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #33787   +/-   ##
=========================================
  Coverage     57.47%   57.47%           
  Complexity     1474     1474           
=========================================
  Files           984      984           
  Lines        155731   155731           
  Branches       1076     1076           
=========================================
  Hits          89499    89499           
  Misses        64023    64023           
  Partials       2209     2209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shunping
Copy link
Copy Markdown
Collaborator Author

The Java ones are all green now! https://github.com/apache/beam/actions/runs/13039436766

tomstepp pushed a commit to tomstepp/apache-beam that referenced this pull request Feb 3, 2025
* Use cached license files during pulling licenses.

* Minor fix on logging.
VardhanThigle pushed a commit to VardhanThigle/beam that referenced this pull request Mar 21, 2025
* Use cached license files during pulling licenses.

* Minor fix on logging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants