Skip to content

Add dry run option to DataflowRunner in python SDK#3385

Closed
vikkyrk wants to merge 1 commit intoapache:masterfrom
vikkyrk:df_runner_dry_run
Closed

Add dry run option to DataflowRunner in python SDK#3385
vikkyrk wants to merge 1 commit intoapache:masterfrom
vikkyrk:df_runner_dry_run

Conversation

@vikkyrk
Copy link
Contributor

@vikkyrk vikkyrk commented Jun 17, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@vikkyrk
Copy link
Contributor Author

vikkyrk commented Jun 17, 2017

R: @robertwb

@robertwb
Copy link
Contributor

Could we perhaps add this as a pipeline option so p.run() (including called implicitly by being a context) would still work rather than having to store the runner and call runner.run(p)?

@vikkyrk
Copy link
Contributor Author

vikkyrk commented Jun 17, 2017

Yes I think would be better. Where would option be defined under, TestOptions maybe?

@robertwb
Copy link
Contributor

robertwb commented Jun 17, 2017 via email

@vikkyrk
Copy link
Contributor Author

vikkyrk commented Jun 17, 2017

Done

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 70.672% when pulling 2f23c00 on vikkyrk:df_runner_dry_run into 0cabdf6 on apache:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 70.681% when pulling 2f23c00 on vikkyrk:df_runner_dry_run into 0cabdf6 on apache:master.

@vikkyrk
Copy link
Contributor Author

vikkyrk commented Jun 19, 2017

Retest this please

@robertwb
Copy link
Contributor

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.695% when pulling 2f23c00 on vikkyrk:df_runner_dry_run into 0cabdf6 on apache:master.

@asfgit asfgit closed this in 1476f34 Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants