Add dry run option to DataflowRunner in python SDK#3385
Closed
vikkyrk wants to merge 1 commit intoapache:masterfrom
vikkyrk:df_runner_dry_run
Closed
Add dry run option to DataflowRunner in python SDK#3385vikkyrk wants to merge 1 commit intoapache:masterfrom vikkyrk:df_runner_dry_run
vikkyrk wants to merge 1 commit intoapache:masterfrom
vikkyrk:df_runner_dry_run
Conversation
Contributor
Author
|
R: @robertwb |
4 tasks
Contributor
|
Could we perhaps add this as a pipeline option so |
Contributor
Author
|
Yes I think would be better. Where would option be defined under, |
Contributor
|
+1 to TestOptions.
…On Fri, Jun 16, 2017 at 5:54 PM, Vikas Kedigehalli ***@***.***> wrote:
Yes I think would be better. Where would option be defined under,
TestOptions maybe?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Contributor
Author
|
Done |
Contributor
Author
|
Retest this please |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.