Skip to content

Beam-2461 Ln function#3387

Closed
app-tarush wants to merge 1 commit intoapache:DSL_SQLfrom
app-tarush:beam-2461-ln-func
Closed

Beam-2461 Ln function#3387
app-tarush wants to merge 1 commit intoapache:DSL_SQLfrom
app-tarush:beam-2461-ln-func

Conversation

@app-tarush
Copy link
Contributor

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0c4c26f on app-tarush:beam-2461-ln-func into ** on apache:DSL_SQL**.

@app-tarush
Copy link
Contributor Author

@takidau Please review this PR #3387. This also includes implementations of other functions log10 and exp.

@takidau
Copy link
Contributor

takidau commented Jun 21, 2017

Apologies for the delay. Some fires elsewhere came up and then I'm in training all day today and tomorrow. Will try to get this and other PRs taken care of later today if possible. Thanks for your patience.

@app-tarush
Copy link
Contributor Author

@takidau @xumingming No worries, actually I have clubbed this PR with another PR #3400.

@takidau
Copy link
Contributor

takidau commented Jun 22, 2017

No problem, please close this one then.

@app-tarush
Copy link
Contributor Author

Closing this PR as this pr has been merged with PR #3400

@app-tarush app-tarush closed this Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants