add endpoint type to WorkerMetadataResponse proto #33953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Contributor
Author
|
assign set of reviewers |
Contributor
Author
|
r: @scwhittle |
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Contributor
|
Deferring to Sam on this one since I don't have context :) |
scwhittle
requested changes
Feb 19, 2025
| DIRECTPATH = 3; | ||
| } | ||
|
|
||
| optional EndpointType endpoint_type = 6; |
scwhittle
approved these changes
Feb 19, 2025
VardhanThigle
pushed a commit
to VardhanThigle/beam
that referenced
this pull request
Mar 21, 2025
* add endpoint type to WorkerMetadataResponse proto * add default value to endpoint_type
Abacn
added a commit
that referenced
this pull request
Mar 27, 2025
#34024) * #34009 avro generic record to beam row conversion added support for all logical types and conversions * using string comparison to avoid class not found issues with earlier versions of avro * using string comparison to avoid class not found issues with earlier versions of avro * com.github.davidmc24.gradle.plugin:gradle-avro-plugin:1.9.1 * using string comparison to avoid class not found issues with earlier versions of avro * com.github.davidmc24.gradle.plugin:gradle-avro-plugin:1.9.1 * Add `types.Unalias` to types assertions and types switches to get an underlying type instead of types.Alias (#33868) * Revert huggingface transformers to 4.30.0 (#34025) * add endpoint type to WorkerMetadataResponse proto (#33953) * add endpoint type to WorkerMetadataResponse proto * add default value to endpoint_type * add hashcode/equals to WaitTest helper classes to avoid log error (#34006) * Add enable_lineage experiment to Dataflow tests (#34027) * Add UUID support in SpannerSchema (#34034) * Add UUID support in Spanner Schema * Add test * fix dashboard link (#34023) * [Go SDK] Add missing type inspection case for Alias types. (#34039) * removed unneeded license header * remove unneeded license header * Added tests for specific records generated with avro 1.8.2 and 1.9.2, and to add custom conversions * Supporting different UUID representations in different avro versions * Spotless fixes * fix dependency typo --------- Co-authored-by: Alfredo Scaccialepre <alfredo.scaccialepre@edreamsodigeo.com> Co-authored-by: synenka <97878236+synenka@users.noreply.github.com> Co-authored-by: Vitaly Terentyev <vitaly.terentyev@akvelon.com> Co-authored-by: martin trieu <martinkt@google.com> Co-authored-by: scwhittle <scwhittle@users.noreply.github.com> Co-authored-by: Yi Hu <yathu@google.com> Co-authored-by: Luv Agarwal <luvagarwal.k@gmail.com> Co-authored-by: Ahmed Abualsaud <65791736+ahmedabu98@users.noreply.github.com> Co-authored-by: Robert Burke <lostluck@users.noreply.github.com>
liferoad
pushed a commit
to liferoad/beam
that referenced
this pull request
Apr 4, 2025
… for a… (apache#34024) * apache#34009 avro generic record to beam row conversion added support for all logical types and conversions * using string comparison to avoid class not found issues with earlier versions of avro * using string comparison to avoid class not found issues with earlier versions of avro * com.github.davidmc24.gradle.plugin:gradle-avro-plugin:1.9.1 * using string comparison to avoid class not found issues with earlier versions of avro * com.github.davidmc24.gradle.plugin:gradle-avro-plugin:1.9.1 * Add `types.Unalias` to types assertions and types switches to get an underlying type instead of types.Alias (apache#33868) * Revert huggingface transformers to 4.30.0 (apache#34025) * add endpoint type to WorkerMetadataResponse proto (apache#33953) * add endpoint type to WorkerMetadataResponse proto * add default value to endpoint_type * add hashcode/equals to WaitTest helper classes to avoid log error (apache#34006) * Add enable_lineage experiment to Dataflow tests (apache#34027) * Add UUID support in SpannerSchema (apache#34034) * Add UUID support in Spanner Schema * Add test * fix dashboard link (apache#34023) * [Go SDK] Add missing type inspection case for Alias types. (apache#34039) * removed unneeded license header * remove unneeded license header * Added tests for specific records generated with avro 1.8.2 and 1.9.2, and to add custom conversions * Supporting different UUID representations in different avro versions * Spotless fixes * fix dependency typo --------- Co-authored-by: Alfredo Scaccialepre <alfredo.scaccialepre@edreamsodigeo.com> Co-authored-by: synenka <97878236+synenka@users.noreply.github.com> Co-authored-by: Vitaly Terentyev <vitaly.terentyev@akvelon.com> Co-authored-by: martin trieu <martinkt@google.com> Co-authored-by: scwhittle <scwhittle@users.noreply.github.com> Co-authored-by: Yi Hu <yathu@google.com> Co-authored-by: Luv Agarwal <luvagarwal.k@gmail.com> Co-authored-by: Ahmed Abualsaud <65791736+ahmedabu98@users.noreply.github.com> Co-authored-by: Robert Burke <lostluck@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @scwhittle
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.