[BEAM-2477] BeamAggregationRel should use Combine.perKey instead of GroupByKey#3398
Closed
JingsongLi wants to merge 1 commit intoapache:DSL_SQLfrom
Closed
[BEAM-2477] BeamAggregationRel should use Combine.perKey instead of GroupByKey#3398JingsongLi wants to merge 1 commit intoapache:DSL_SQLfrom
JingsongLi wants to merge 1 commit intoapache:DSL_SQLfrom
Conversation
Contributor
Author
Contributor
Author
|
retest this please |
1 similar comment
Contributor
Author
|
retest this please |
mingmxu
approved these changes
Jun 22, 2017
mingmxu
left a comment
mingmxu
left a comment
There was a problem hiding this comment.
Thanks @JingsongLi
LGTM, given that Combine.perKey equals with GroupByKey, and there's lot of optimization in Combine.perKey.
Contributor
|
Thanks a lot, nice improvement. LGTM. Will merge as soon as I can. |
Contributor
|
Merged, feel free to close. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.