fix: correct spanner column schema type parser#34867
Merged
Abacn merged 1 commit intoapache:masterfrom May 6, 2025
Merged
Conversation
Regex for parsing array types did not take into account sized primitive types, eg ARRAY<STRING(MAX)> Fixes apache#34863
Abacn
approved these changes
May 6, 2025
Contributor
Abacn
left a comment
Abacn
left a comment
There was a problem hiding this comment.
Confirmed that the added test failed on current HEAD with
java.lang.IllegalArgumentException: Invalid ARRAY type: ARRAY<STRING(MAX)>
at org.apache.beam.sdk.io.gcp.spanner.SpannerSchema$Column.parseSpannerType(SpannerSchema.java:223)
and succeeded on this PR. Thanks for the quick fix!
Deep1998
reviewed
May 6, 2025
...oogle-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerSchemaTest.java
Show resolved
Hide resolved
nielm
changed the title
nielm
changed the title
Contributor
|
testAtLeastOnceDynamicDestinationsWithAutoSchemaUpdate[1] (org.apache.beam.sdk.io.gcp.bigquery.StorageApiSinkSchemaUpdateIT) failed not related to this change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regex for parsing array types did not take into account sized primitive types, eg ARRAY<STRING(MAX)>
Fixes #34863
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.