Skip to content

[BEAM-2565] add integration test for conditional functions#3570

Closed
xumingming wants to merge 2 commits intoapache:DSL_SQLfrom
xumingming:BEAM-2565-integration-test-for-case-operator
Closed

[BEAM-2565] add integration test for conditional functions#3570
xumingming wants to merge 2 commits intoapache:DSL_SQLfrom
xumingming:BEAM-2565-integration-test-for-case-operator

Conversation

@xumingming
Copy link
Contributor

@xumingming
Copy link
Contributor Author

Retest this please

@xumingming xumingming force-pushed the BEAM-2565-integration-test-for-case-operator branch from 04f5011 to 43e6d31 Compare July 18, 2017 03:32
@xumingming
Copy link
Contributor Author

Retest this please

@@ -0,0 +1,43 @@
package org.apache.beam.dsls.sql.integrationtest;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add license info

@xumingming
Copy link
Contributor Author

Added license info.

Copy link

@mingmxu mingmxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xumingming
LGTM now

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3b93c4a on xumingming:BEAM-2565-integration-test-for-case-operator into ** on apache:DSL_SQL**.

@JingsongLi
Copy link
Contributor

+R @JingsongLi, I'll take a quick look.

asfgit pushed a commit that referenced this pull request Jul 18, 2017
@JingsongLi
Copy link
Contributor

Merged. Feel free to close.

@xumingming
Copy link
Contributor Author

Thanks @JingsongLi @xumingmin !

@xumingming xumingming closed this Jul 18, 2017
@xumingming xumingming deleted the BEAM-2565-integration-test-for-case-operator branch July 18, 2017 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants