Skip to content

[BEAM-2636] Make sure we only override the correct class for WriteToBigQuery#3595

Closed
sb2nov wants to merge 1 commit intoapache:masterfrom
sb2nov:BEAM-2636-bq-override
Closed

[BEAM-2636] Make sure we only override the correct class for WriteToBigQuery#3595
sb2nov wants to merge 1 commit intoapache:masterfrom
sb2nov:BEAM-2636-bq-override

Conversation

@sb2nov
Copy link
Contributor

@sb2nov sb2nov commented Jul 19, 2017

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @aaltay PTAL

@aaltay
Copy link
Member

aaltay commented Jul 19, 2017

LGTM. I will merge after tests pass.

Please send a CP PR, if there will be an RC3 for the current release.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 70.627% when pulling 9056783 on sb2nov:BEAM-2636-bq-override into a6f460f on apache:master.

@sb2nov
Copy link
Contributor Author

sb2nov commented Jul 19, 2017

Thanks will do the cherry pick if there is a new RC

@asfgit asfgit closed this in 2e51bde Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants