Translate reads/sources through the Runner API#3635
Closed
robertwb wants to merge 3 commits into
Closed
Conversation
robertwb
force-pushed
the
runner-api-read-good
branch
from
61db58c to
a2e097e
Compare
robertwb
changed the title
Contributor
Author
|
R: @sb2nov |
sb2nov
reviewed
Jul 25, 2017
|
|
||
| @staticmethod | ||
| def from_runner_api_parameter(parameter, context): | ||
| return Read(BoundedSource.from_runner_api(parameter.source, context)) |
Contributor
There was a problem hiding this comment.
why is this always a bounded source? based on the to_runner_api function it can be both bounded and unbounded
Contributor
Author
There was a problem hiding this comment.
Because we don't have an UnboundedSource. We do, however, have a (separate) NativeSource which I just now realized may be an issue. Made a common superclass.
robertwb
force-pushed
the
runner-api-read-good
branch
from
6ab3faf to
210c857
Compare
Contributor
|
LGTM if tests pass. |
Contributor
Author
|
Irrelevant java failure. Retest this please. |
|
Changes Unknown when pulling 210c857 on robertwb:runner-api-read-good into ** on apache:master**. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.