[proposal] Improving naming of steps that consume side inputs#3659
Closed
pabloem wants to merge 1 commit intoapache:masterfrom
Closed
[proposal] Improving naming of steps that consume side inputs#3659pabloem wants to merge 1 commit intoapache:masterfrom
pabloem wants to merge 1 commit intoapache:masterfrom
Conversation
robertwb
approved these changes
Jul 31, 2017
Contributor
robertwb
left a comment
robertwb
left a comment
There was a problem hiding this comment.
Yeah, that looks better.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would allow steps which consume side inputs to have a more intuitive name. We've had several users express confusion about their counters being associated to a step named Do.
The previous appearance was like this:
This change makes it look like this:
r: @robertwb what do you think about this?