[BEAM-2708] Adds support for reading concatenated bzip2 files#3678
Closed
chamikaramj wants to merge 2 commits intoapache:masterfrom
Closed
[BEAM-2708] Adds support for reading concatenated bzip2 files#3678chamikaramj wants to merge 2 commits intoapache:masterfrom
chamikaramj wants to merge 2 commits intoapache:masterfrom
Conversation
Adds tests for concatenated gzip and bzip2 files. Removes test 'test_model_textio_gzip_concatenated' in 'snippets_test.py' since it's actually hitting 'DummyReadTransform' and not testing this feature.
Contributor
Author
aaltay
reviewed
Aug 3, 2017
Member
aaltay
left a comment
aaltay
left a comment
There was a problem hiding this comment.
LGTM after fixing the minor comments. Thank you.
Please consider CPing this to the release branch.
| pipeline.run() | ||
|
|
||
| def test_read_gzip_concat(self): | ||
| # gzip_file_name1 = temp_path_1 + '.gz' |
| self._read_buffer.write(decompressed) | ||
| continue | ||
| else: | ||
| # Gzip and bzip2 formats do not require flusing remaining data in the |
Contributor
Author
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for concatenated gzip and bzip2 files.
Removes test 'test_model_textio_gzip_concatenated' in 'snippets_test.py' since it's actually hitting 'DummyReadTransform' and not testing this feature.