Skip to content

[BEAM-2733] update javadoc for BeamSql#3704

Closed
xumingming wants to merge 1 commit intoapache:DSL_SQLfrom
xumingming:BEAM-2733-BeamSql
Closed

[BEAM-2733] update javadoc for BeamSql#3704
xumingming wants to merge 1 commit intoapache:DSL_SQLfrom
xumingming:BEAM-2733-BeamSql

Conversation

@xumingming
Copy link
Copy Markdown
Contributor

@xumingming xumingming commented Aug 8, 2017

Summary:

  • Exception declaration are removed from BeamSql.query ()
  • Added javadoc to explain when the sql query use a non-exist table、a subset of tables from upstream, what happens.
  • Added javadoc for BeamSql.query and QueryTransform to describe the lifetime of tables in PCollectionTuple.
  • SimpleQueryTransform and QueryTransform are actually user-facing (they are return types of query() and simpleQuery()), so they are kept public.

@xumingming
Copy link
Copy Markdown
Contributor Author

xumingming commented Aug 8, 2017

R: @xumingmin @takidau

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 8, 2017

Coverage Status

Changes Unknown when pulling df4d24f on xumingming:BEAM-2733-BeamSql into ** on apache:DSL_SQL**.

takidau
takidau approved these changes Aug 8, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@takidau takidau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging.

mingmxu
mingmxu approved these changes Aug 8, 2017
View reviewed changes
Copy link
Copy Markdown

@mingmxu mingmxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @xumingming

asfgit pushed a commit that referenced this pull request Aug 8, 2017
@takidau
[BEAM-2733] This closes #3704
d7120f0
@takidau
Copy link
Copy Markdown
Contributor

takidau commented Aug 8, 2017

Merged, please feel free to close.

@xumingming xumingming closed this Aug 9, 2017
@xumingming xumingming deleted the BEAM-2733-BeamSql branch August 9, 2017 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@takidau takidau takidau approved these changes

+1 more reviewer

@mingmxu mingmxu mingmxu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xumingming @coveralls @takidau @mingmxu