Closed
Conversation
Author
|
R: + @xumingming |
Contributor
|
Just out of curiosity, what's the reason that Tyler's previous try failed? |
Author
|
I don't find the cause, possibly some libraries are broken. It may happens as DSL_SQL uses the same version as master, however the two branches are quite different so far.
…Sent from my iPhone
On Aug 8, 2017, at 11:30 PM, James Xu ***@***.***> wrote:
@xumingming approved this pull request.
LGTM
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
takidau
approved these changes
Aug 9, 2017
Contributor
takidau
left a comment
takidau
left a comment
There was a problem hiding this comment.
LGTM.
The cause of the build problems was just maven, or my inability to use maven properly, depending on how you want to look at it. ;-) Basically I need to learn to not trust maven and just do a clean install anytime something seems funky, and everything will probably be fine. :-)
I'll merge this tomorrow morning.
Author
|
Glad to know that it works in your env now, |
Contributor
|
Merged, feel free to close. Thank you! |
Author
|
close #3706, thank you @takidau @xumingming |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R: @takidau