Skip to content

Comments

Simplify wheel validation logic.#37687

Open
tvalentyn wants to merge 1 commit intoapache:masterfrom
tvalentyn:wheels_2
Open

Simplify wheel validation logic.#37687
tvalentyn wants to merge 1 commit intoapache:masterfrom
tvalentyn:wheels_2

Conversation

@tvalentyn
Copy link
Contributor

fixes: #37671


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tvalentyn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Python SDK wheel identification and installation process within the container boot sequence. By eliminating the need for explicit, version-dependent wheel specification validation, the system now uses a more direct and flexible approach to locate the correct SDK wheel. This change reduces code complexity and improves the maintainability of the container's setup logic.

Highlights

  • Simplified Wheel Validation: The logic for validating and identifying Python wheels, specifically for the Apache Beam SDK, has been significantly simplified by removing version-specific checks.
  • Removed Unnecessary Code: The setupAcceptableWheelSpecs function, the acceptableWhlSpecs global variable, and the regexp import, all related to the previous wheel validation, have been removed.
  • Streamlined SDK Installation: The installSdk and findBeamSdkWhl functions were updated to reflect the simplified wheel identification, reducing their parameter lists and internal complexity.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • sdks/python/container/boot.go
    • Removed the regexp import.
    • Eliminated the acceptableWhlSpecs global variable.
    • Deleted the setupAcceptableWheelSpecs function, which was responsible for determining acceptable wheel specifications.
    • Updated the installSetupPackages function to remove calls to the setupAcceptableWheelSpecs function and simplify the arguments passed to installSdk.
  • sdks/python/container/piputil.go
    • Modified the findBeamSdkWhl function signature to remove the acceptableWhlSpecs parameter and simplified its internal logic to identify wheels based on a .whl suffix.
    • Adjusted the installSdk function signature and its internal call to findBeamSdkWhl to no longer require the acceptableWhlSpecs parameter.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@tvalentyn tvalentyn mentioned this pull request Feb 23, 2026
3 tasks
@tvalentyn
Copy link
Contributor Author

Tested that any wheel name gets picked up:

DEBUG 2026-02-23T20:10:32.410470614Z Found Apache Beam SDK wheel: apache_beam-2.73.0.dev0-cp313-cp313-manylinux_2_17_x86_96.manylinux2014_x86_96.whl
ERROR 2026-02-23T20:10:32.959998007Z ERROR: apache_beam-2.73.0.dev0-cp313-cp313-manylinux_2_17_x86_96.manylinux2014_x86_96.whl is not a supported wheel on this platform.

@tvalentyn
Copy link
Contributor Author

R: @shunping or @damccorm or @Amar3tto

@tvalentyn tvalentyn marked this pull request as ready for review February 23, 2026 20:12
@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers


// setupAcceptableWheelSpecs setup wheel specs according to installed python version
func setupAcceptableWheelSpecs() error {
cmd := exec.Command("python", "-V")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this lead to us getting the wheel for the wrong python version? If yes, should we at least keep that piece of the check? (e.g. check if it contains cp313)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is possible if there is more than 1 wheel staged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated logic.

@tvalentyn
Copy link
Contributor Author

Tested the logic in https://pantheon.corp.google.com/dataflow/jobs/us-central1/2026-02-23_14_45_12-15094072168847210212 purposely using a wheel that doesn't match prior naming patterns.

@tvalentyn tvalentyn changed the title Simply wheel validation logic. Simplify wheel validation logic. Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants