[ErrorProne] Enable StringCharset Check

[stankiewicz]

This PR enables the StringCharset Error Prone check across the repository by removing it from the disabledChecks list in BeamModulePlugin.groovy
Additionally, it resolves the resulting compilation failures in affected modules by modernizing character set string usages—specifically, replacing the string literal "UTF-8" (and "UTF8") with StandardCharsets.UTF_8 where String.getBytes() or new String() were used.

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves code quality and robustness by enabling the StringCharset Error Prone check. This change enforces the use of StandardCharsets constants for character encoding, eliminating the potential for UnsupportedEncodingException and making character set handling more explicit and reliable throughout the codebase. The necessary code modifications were made to resolve compilation failures introduced by enabling this check.

Highlights

• Error Prone Check Enabled: The StringCharset Error Prone check has been enabled across the repository by removing it from the disabledChecks list.
• Character Set Modernization: All instances of string literals like "UTF-8" and "UTF8" used for character encoding in String.getBytes() and new String() constructors have been replaced with StandardCharsets.UTF_8.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
  • Removed "StringCharset" from the list of disabled Error Prone checks.
• examples/java/src/main/java/org/apache/beam/examples/complete/game/injector/Injector.java
  • Updated getBytes() and OutputStreamWriter constructors to use StandardCharsets.UTF_8 for character encoding.
• sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/JsonSchemaConversionTest.java
  • Replaced string literal "UTF-8" with StandardCharsets.UTF_8 in String constructor calls.
• sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaDlqTest.java
  • Modified getBytes() calls to use StandardCharsets.UTF_8 instead of "UTF8".
• sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaIOExternalTest.java
  • Replaced string literal "UTF-8" with StandardCharsets.UTF_8 in String constructor calls for assertions.
• sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaWriteSchemaTransformProviderTest.java
  • Updated getBytes() calls to use StandardCharsets.UTF_8 and removed the UnsupportedEncodingException import.

Activity

• The pull request was created by stankiewicz.
• No human activity (comments, reviews, approvals) has occurred on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[stankiewicz]

assign set of reviewers

[github-actions]

Assigning reviewers:

R: @chamikaramj for label java.
R: @damccorm for label build.
R: @Dippatel98 for label kafka.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).