[Dataflow Streaming] Create a separate option to control commit threads with direct path.

[arunpandianp]

The number of direct path commit threads will be per backend windmill worker.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the configurability of Dataflow Streaming jobs by introducing a dedicated option to manage the number of commit threads specifically for direct path operations. This change allows for more granular control over resource allocation and performance tuning for streaming pipelines utilizing the direct path, ensuring that commit operations can be optimized independently of general commit threads.

Highlights

• New Configuration Option: Introduced a new pipeline option, WindmillServiceDirectPathCommitThreads, to specifically control the number of commit threads per backend Windmill worker when using the streaming engine's direct path mode.
• Worker Logic Update: Modified the StreamingDataflowWorker to utilize the newly introduced WindmillServiceDirectPathCommitThreads option for configuring the number of commit senders in direct path scenarios, ensuring dedicated control over these resources.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowStreamingPipelineOptions.java
  • Added a new pipeline option WindmillServiceDirectPathCommitThreads with a default value of 1.
  • Provided a description for the new option indicating its purpose for direct path commit threads.
• runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java
  • Modified the StreamingDataflowWorker to use the new WindmillServiceDirectPathCommitThreads option instead of the general WindmillServiceCommitThreads for setting the number of commit senders in direct path mode.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[arunpandianp]

R: @scwhittle

cc: @parveensania

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers