Skip to content

[JStorm-runner] Fix two issues of metrics reporter and waiting time on local mode#3789

Closed
bastiliu wants to merge 2 commits intoapache:jstorm-runnerfrom
bastiliu:jstorm-runner
Closed

[JStorm-runner] Fix two issues of metrics reporter and waiting time on local mode#3789
bastiliu wants to merge 2 commits intoapache:jstorm-runnerfrom
bastiliu:jstorm-runner

Conversation

@bastiliu
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@bastiliu
Copy link
Contributor Author

@peihe
Could you please help to review the fixes?

@bastiliu bastiliu changed the title [JStorm-runner] Bug fix [JStorm-runner] Fix two issues of metrics reporter and waiting time on local mode Aug 30, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 99c06fb on bastiliu:jstorm-runner into ** on apache:jstorm-runner**.

@peihe
Copy link
Contributor

peihe commented Aug 30, 2017

retest this please

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 99c06fb on bastiliu:jstorm-runner into ** on apache:jstorm-runner**.

@peihe
Copy link
Contributor

peihe commented Aug 30, 2017

R: +@peihe

LGTM

This PR looks good by itself, failed tests were due to metrics fixes revealed the test flakiness.

asfgit pushed a commit that referenced this pull request Aug 30, 2017
@bastiliu
Copy link
Contributor Author

Merged and close.

@bastiliu bastiliu closed this Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants