Skip to content

Handle Flink 2 job server tag in releases and SDK snapshot#37939

Merged
Abacn merged 1 commit intoapache:masterfrom
Abacn:fix-flink-tag
Mar 24, 2026
Merged

Handle Flink 2 job server tag in releases and SDK snapshot#37939
Abacn merged 1 commit intoapache:masterfrom
Abacn:fix-flink-tag

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Mar 24, 2026

Please add a meaningful description for your change here

Apparently the tag added locally and used for push uses different configuration

Locally it's tagged via containerImageName(tag), but for push it uses tags config in BeamDockerPlugin.

Tested locally using ./gradlew :runners:flink:2.0:job-server-container:dockerPush -Pdocker-repository-root=gcr.io/apache-beam-testing/beam_portability -Pdocker-tag-list=testtag,latest,

gcr.io/apache-beam-testing/beam_portability/beam_flink_job_server

has -flink2.0 suffixed tags added.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the Docker image tagging strategy within the Beam build system. It introduces a flexible mechanism to append version-specific suffixes to Docker image tags, which is then applied to correctly identify Flink 2 job server containers. This ensures that images for different Flink versions are distinctly and consistently tagged, improving clarity and management in release and snapshot processes.

Highlights

  • Enhanced Docker Tagging: Introduced a tagSuffix property in the BeamDockerPlugin to allow appending a consistent suffix to all generated Docker image tags.
  • Flink 2 Job Server Tagging: Implemented the tagSuffix mechanism for Flink 2 job server container images, ensuring that version-specific suffixes (e.g., -flink2) are correctly and consistently applied to all relevant tags during releases and SDK snapshots.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/finalize_release.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Abacn
Copy link
Contributor Author

Abacn commented Mar 24, 2026

R: @Amar3tto @damccorm

Just FYI for 2.72.0rc5 I've added "2.72.0rc5-flink2.0" tag manually

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn Abacn merged commit 7187ff6 into apache:master Mar 24, 2026
29 checks passed
@Abacn Abacn deleted the fix-flink-tag branch March 24, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants