Handle Flink 2 job server tag in releases and SDK snapshot#37939
Handle Flink 2 job server tag in releases and SDK snapshot#37939Abacn merged 1 commit intoapache:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the Docker image tagging strategy within the Beam build system. It introduces a flexible mechanism to append version-specific suffixes to Docker image tags, which is then applied to correctly identify Flink 2 job server containers. This ensures that images for different Flink versions are distinctly and consistently tagged, improving clarity and management in release and snapshot processes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Please add a meaningful description for your change here
Apparently the tag added locally and used for push uses different configuration
Locally it's tagged via
containerImageName(tag), but for push it uses tags config inBeamDockerPlugin.Tested locally using
./gradlew :runners:flink:2.0:job-server-container:dockerPush -Pdocker-repository-root=gcr.io/apache-beam-testing/beam_portability -Pdocker-tag-list=testtag,latest,gcr.io/apache-beam-testing/beam_portability/beam_flink_job_server
has
-flink2.0suffixed tags added.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.