Skip to content

Remove log message waitStrategy for ClickhouseResourceManager #37951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abacn wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −8
Open

Remove log message waitStrategy for ClickhouseResourceManager #37951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions it/clickhouse/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ dependencies {
implementation library.java.testcontainers_base
implementation library.java.testcontainers_clickhouse
implementation "com.clickhouse:client-v2:$clickhouse_java_client_version:all"
runtimeOnly "com.clickhouse:clickhouse-jdbc:$clickhouse_java_client_version:all"
implementation "com.clickhouse:clickhouse-jdbc:$clickhouse_java_client_version:all"

testImplementation(library.java.truth)
testImplementation 'junit:junit:4.13.2'
Expand All @@ -51,5 +51,5 @@ dependencies {
testRuntimeOnly library.java.slf4j_simple

permitUnusedDeclared "com.clickhouse:client-v2:$clickhouse_java_client_version:all"

permitUnusedDeclared "com.clickhouse:clickhouse-jdbc:$clickhouse_java_client_version:all"
}
6 changes: 0 additions & 6 deletions it/clickhouse/src/main/java/org/apache/beam/it/clickhouse/ClickHouseResourceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import java.sql.ResultSetMetaData;
import java.sql.SQLException;
import java.sql.Statement;
import java.time.Duration;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
Expand All @@ -38,7 +37,6 @@
import org.slf4j.LoggerFactory;
import org.testcontainers.clickhouse.ClickHouseContainer;
import org.testcontainers.containers.GenericContainer;
import org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy;
import org.testcontainers.utility.DockerImageName;

/**
Expand Down Expand Up @@ -74,10 +72,6 @@ private static ClickHouseContainer buildContainer(Builder builder) {
DockerImageName.parse(builder.containerImageName)
.withTag(builder.containerImageTag))
.withStartupAttempts(10);

Duration startupTimeout = Duration.ofMinutes(2);
container.setWaitStrategy(new LogMessageWaitStrategy().withStartupTimeout(startupTimeout));

return container;
}

Expand Down
Loading