Skip to content

Enable SpannerChangeStreamPlacementTableIT and update IntegrationTest… #38052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 1 commit into from
Apr 3, 2026
Merged

Enable SpannerChangeStreamPlacementTableIT and update IntegrationTest… #38052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/it/IntegrationTestEnv.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,12 @@ protected void after() {
.get(TIMEOUT_MINUTES, TimeUnit.MINUTES);
}
} catch (Exception e) {
LOG.error("Failed to drop table {}. Skipping...", table, e);
if (isPlacementTableBasedChangeStream) {
// Drop placement table requires all rows deleted and garbage collected.
LOG.info("Failed to drop table {}. Skipping...", table, e);
} else {
LOG.error("Failed to drop table {}. Skipping...", table, e);
}
}
}

Expand Down
11 changes: 6 additions & 5 deletions .../apache/beam/sdk/io/gcp/spanner/changestreams/it/SpannerChangeStreamPlacementTableIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
import org.junit.Before;
import org.junit.BeforeClass;
import org.junit.ClassRule;
import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.ExpectedException;
Expand All @@ -66,12 +65,14 @@

/** End-to-end test of Cloud Spanner placement table. */
@RunWith(JUnit4.class)
@Ignore(
"TODO: enable this test class when placement table is supported by change stream in prod."
+ "For now this test can only be exercised mannually.")
public class SpannerChangeStreamPlacementTableIT {

@ClassRule public static final IntegrationTestEnv ENV = new IntegrationTestEnv();
@ClassRule
public static final IntegrationTestEnv ENV =
new IntegrationTestEnv(
/*isPostgres=*/ false,
/*isPlacementTableBasedChangeStream=*/ true,
/*host=*/ Optional.empty());

@Rule public final transient TestPipeline pipeline = TestPipeline.create();

Expand Down
Loading