Skip to content

Portable Date Type (Java + model changes)#38077

Merged
ahmedabu98 merged 1 commit intoapache:masterfrom
ahmedabu98:portable_date_java
Apr 6, 2026
Merged

Portable Date Type (Java + model changes)#38077
ahmedabu98 merged 1 commit intoapache:masterfrom
ahmedabu98:portable_date_java

Conversation

@ahmedabu98
Copy link
Copy Markdown
Contributor

Part 1/2 of #37830

@github-actions github-actions bot added the java label Apr 5, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a portable Date logical type to the Apache Beam schema system. By defining this type in the schema protocol buffer and updating the Java SDK and JDBC utility classes, it enables consistent handling of date values without timezones across different environments and data sources.

Highlights

  • Schema Definition: Added a new DATE logical type definition to the schema protocol buffer.
  • Java SDK Updates: Updated SchemaTranslation and the Date logical type implementation to support the new portable DATE type.
  • JDBC Integration: Enhanced JdbcUtil to handle the new DATE logical type during prepared statement parameter setting.
  • Testing: Added test cases to SchemaTranslationTest to verify the serialization and deserialization of the new DATE type.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

Assigning reviewers:

R: @chamikaramj for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@ahmedabu98 ahmedabu98 merged commit c1e44fb into apache:master Apr 6, 2026
147 of 172 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants