Skip to content

jstorm-runner: support SourceMetrics, distribution metrics, and saves MetricsResults after cancelling.#3812

Closed
peihe wants to merge 4 commits intoapache:jstorm-runnerfrom
peihe:jstorm-runner-9
Closed

jstorm-runner: support SourceMetrics, distribution metrics, and saves MetricsResults after cancelling.#3812
peihe wants to merge 4 commits intoapache:jstorm-runnerfrom
peihe:jstorm-runner-9

Conversation

@peihe
Copy link
Contributor

@peihe peihe commented Sep 6, 2017

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@peihe
Copy link
Contributor Author

peihe commented Sep 6, 2017

R: @bastiliu

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 77d486a on peihe:jstorm-runner-9 into ** on apache:jstorm-runner**.

@bastiliu
Copy link
Contributor

bastiliu commented Sep 7, 2017

LGTM.
Just a minor comment. The Histogram in JStorm keeps a reservoir with fixed records. It means the values of Histogram snapshot is not very accurate to calculate the sum and count of distribution metrics. If we didn't have a better solution now, I think it is OK to leave a TODO here for further improvement.

@peihe
Copy link
Contributor Author

peihe commented Sep 7, 2017

Added TODO

+R: @JingsongLi

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 599db6b on peihe:jstorm-runner-9 into ** on apache:jstorm-runner**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0a457b5 on peihe:jstorm-runner-9 into ** on apache:jstorm-runner**.

@peihe
Copy link
Contributor Author

peihe commented Sep 7, 2017

retest this please

1 similar comment
@peihe
Copy link
Contributor Author

peihe commented Sep 7, 2017

retest this please

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0a457b5 on peihe:jstorm-runner-9 into ** on apache:jstorm-runner**.

@JingsongLi
Copy link
Contributor

LGTM

@peihe
Copy link
Contributor Author

peihe commented Sep 8, 2017

Thanks, Jingsong!

asfgit pushed a commit that referenced this pull request Sep 8, 2017
@peihe
Copy link
Contributor Author

peihe commented Sep 8, 2017

merged

@peihe peihe closed this Sep 8, 2017
@peihe peihe deleted the jstorm-runner-9 branch September 8, 2017 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants